textmate rules: reclassify true/false/null as literal constants #914
Open
yotam-frid wants to merge 2 commits intogodotengine:masterfrom
Open
textmate rules: reclassify true/false/null as literal constants #914yotam-frid wants to merge 2 commits intogodotengine:masterfrom
yotam-frid wants to merge 2 commits intogodotengine:masterfrom
Conversation
Collaborator
|
What are your screenshots supposed to be demonstrating? I'm fairly certain that true/false/null are being categorized the way I want them to be, so you're going to need to a better reason than this. |
Author
Contributor
|
I think this is a great change; it just aligns the vscode editor to the default godot editor. Is there anything else that needs to be done here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This branch marks the
true/false/nullconsts as language literal constants to mimic the behavior of the engine editor which treats them as such.Before: both

true/falseandVector2.RIGHTtreated as same levelAfter: booleans are in a separate scope (correct behavior)
