Added the ability to specify platform-specific editorPath#905
Open
ogapo wants to merge 2 commits intogodotengine:masterfrom
Open
Added the ability to specify platform-specific editorPath#905ogapo wants to merge 2 commits intogodotengine:masterfrom
ogapo wants to merge 2 commits intogodotengine:masterfrom
Conversation
- support config of the form `godotTools.editorPath.(windows|macos|linux)-(x86_64|arm64).godot(3|4)`
- match godot's buildsystem terms for familiarity
- expand ${env:X} into the string. Previous code replaced the whole string if it contained an env tag and only matched the first one.
- move all path manipulation hacks into clean_godot_path
- tried to make sure all code that needs the editor path consistently use the util functions
Collaborator
|
FYI I'm out of town until next week but I'll review this when I get back. |
Author
|
@DaelonSuzuka wondering if you have any cycles to have a look at this? Thanks! |
Author
|
@DaelonSuzuka or @Calinou wondering if there's any chance you could look at this PR? I think it's pretty much g2g |
Collaborator
|
I've been extremely busy (new job) but I'll try to look at it this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
godotTools.editorPath.(windows|macos|linux)-(x86_64|arm64).godot(3|4)BUGFIX: expand ${env:X} into the string. Previous code replaced the whole string if it contained an env tag and only matched the first one.
Per some discussion on #502 I realized this is the only thing stopping folks from using workspace config (committed to source control) for configuring prebuilt binaries in their projects given the paths are already treated as workspace relative (if they're not absolute).