Skip to content

Use Math::abs to avoid ambiguity with integer abs #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Use Math::abs to avoid ambiguity with integer abs #1770

merged 1 commit into from
Apr 16, 2025

Conversation

Zylann
Copy link
Collaborator

@Zylann Zylann commented Apr 16, 2025

That happened when compiling with Clang on Linux and -Wall: https://github.com/Zylann/godot_voxel/actions/runs/14474467053/job/40596573102

@Zylann Zylann requested a review from a team as a code owner April 16, 2025 18:39
@Zylann Zylann mentioned this pull request Apr 16, 2025
Merged
@dsnopek dsnopek added waiting for Godot This issue needs a Godot Engine improvement to be solved bug This has been identified as a bug labels Apr 16, 2025
@dsnopek dsnopek added this to the 4.x milestone Apr 16, 2025
@dsnopek dsnopek added cherrypick:4.4 and removed waiting for Godot This issue needs a Godot Engine improvement to be solved labels Apr 16, 2025
@dsnopek dsnopek merged commit 70d8ff0 into godotengine:master Apr 16, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@Ivorforce Ivorforce Ivorforce approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug cherrypick:4.4
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@Zylann @dsnopek @Ivorforce