fix: preserve trailing slash in SetBaseURL (fixes #1061) - #1191
Open
ObeeJ wants to merge 1 commit into
Open
Conversation
SetBaseURL was calling strings.TrimRight(url, "/") which silently
dropped a trailing slash. This caused SetBaseURL("http://host/api/")
to resolve empty-path requests to http://host/api instead of
http://host/api/.
Fix:
- Store the URL as-is in SetBaseURL
- In URL composition, use strings.TrimRight only when joining with a
non-empty request path to avoid double-slash; use baseURL as-is
when the request path is empty or "/"
- Update the unescape_query_params test expectation to reflect the
correct URL (trailing slash preserved)
- Add regression test covering empty path, non-empty path, and
both trailing-slash and non-trailing-slash base URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetBaseURLwas callingstrings.TrimRight(url, "/")which silently dropped a trailing slash. This caused:This is a regression of #119 (originally fixed in v1.2).
Fix
SetBaseURL— no strippingmiddleware.go), usestrings.TrimRightonly when joining with a non-empty request path (to avoid double-slash); usebaseURLas-is when the request path is empty or"/"Test cases covered
http://host/api/""http://host/api/✅http://host/api//resourcehttp://host/api/resource✅http://host/api/resourcehttp://host/api/resource✅http://host/""http://host/✅Fixes #1061