Skip to content

fix: potential wrong total time in trace info when the request is invalid (#1016) #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2025

Conversation

git-hulk
Copy link
Contributor

@git-hulk git-hulk commented May 9, 2025

This closes #1016.

Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (036c589) to head (1ad996e).
Report is 1 commits behind head on v3.

Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #1017   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          18       18           
  Lines        3914     3919    +5     
=======================================
+ Hits         3907     3912    +5     
  Misses          5        5           
  Partials        2        2           
Flag Coverage Δ
unittests 99.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@git-hulk git-hulk requested a review from ccoVeille May 10, 2025 00:39
@git-hulk git-hulk force-pushed the fix/latency-in-trace-info branch from 2e1d8e5 to 1ad996e Compare May 10, 2025 00:41
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@git-hulk Thanks for the PR. FYI, you have created a PR agianst v3.

@jeevatkm jeevatkm changed the title Fix potential wrong total time in trace info when the request is invalid fix: potential wrong total time in trace info when the request is invalid (#1016) May 10, 2025
@jeevatkm jeevatkm merged commit 66256ef into go-resty:v3 May 10, 2025
4 checks passed
@jeevatkm jeevatkm added this to the v3.0.0 Milestone milestone May 10, 2025
git-hulk added a commit to git-hulk/resty that referenced this pull request May 11, 2025
@git-hulk
Copy link
Contributor Author

@jeevatkm Thanks for your review.

FYI, you have created a PR agianst v3.

Yes, I see the default branch is v3, so I submitted the PR targeted at it. I have sent another PR #1018 to backport this to v2(we're using the v2 indeed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The total time in trace info may become MAX_INT64 in some invalid requests
3 participants