feat: add validation for weekends#1377
Open
putrafajarh wants to merge 2 commits intogo-playground:masterfrom
Open
feat: add validation for weekends#1377putrafajarh wants to merge 2 commits intogo-playground:masterfrom
putrafajarh wants to merge 2 commits intogo-playground:masterfrom
Conversation
Author
|
Just want to know, if my PR approve, is it better to add another rule |
Contributor
|
Thanks for your contribution! Interesting idea, but the implementation seems limited to a specific date format. |
Author
|
@nodivbyzero it utilize time.Parse, it should work. The problem is according to doc, need to put 0x2C to represent comma |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Added new validation rules
weekendMake sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers