Fixed all grammatical errors in locale_en-US.ini #35053
Conversation
GiteaBot
added
the
lgtm/need 2
|
Based upon casing, I wonder if the period additions for lines 323 and 353 is correct? 1038 and 1039 also read fine to me as they were; the original it's flows better than it is (IMO). 1105 has a url that should probably be URL to match the other instance. |
The period additions in 323 and 353 doesn't matter but i could remove them. |
|
I still see quite a few language issues in the file. The fixes in this PR are great but I would suggest to remove the "all" from the commit message when squashing and merging. Happy to contribute a separate PR after that's done to fix more of the issues. |
GiteaBot
added
lgtm/need 1
| @@ -689,7 +689,7 @@ form.name_chars_not_allowed = User name "%s" contains invalid characters. | |||
|
|
|||
| block.block = Block | |||
| block.block.user = Block user | |||
| block.block.org = Block user for organization | |||
| block.block.org = Block user from organization | |||
There was a problem hiding this comment.
Seems not right
What's the context?
There was a problem hiding this comment.
context: You are blocking a user from an organization which means restricting access to the organization.
Do you think there's something else you had in mind?
There was a problem hiding this comment.
Hmm, not a native speaker, but I think I may misunderstand the new sentence.
It reads like "block a user, the user is from an organization"
Old reads like "block a user, then for the organization, the user will have no access"
What do you think?
| @@ -3831,7 +3831,7 @@ runners.reset_registration_token_success = Runner registration token reset succe | |||
| runs.all_workflows = All Workflows | |||
| runs.commit = Commit | |||
| runs.scheduled = Scheduled | |||
| runs.pushed_by = pushed by | |||
| runs.pushed_by = Pushed by | |||
There was a problem hiding this comment.
IIRC it is used in a context, the old i18n keys are not well designed, but I guess we should keep the old text
There was a problem hiding this comment.
Alright, I will change it to the old text. Please confirm everything is okay with line 692 and I will make an update.
No description provided.