Fix user's sign email check #35045
Merged
Fix user's sign email check #35045
+55
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-sign-email-check
branch
2 times, most recently
from
d8028b3 to
0e90ddf
Compare
wxiaoguang
force-pushed
the
fix-sign-email-check
branch
from
0e90ddf to
ca1b4e8
Compare
lunny
approved these changes
Jul 11, 2025
GiteaBot
added
lgtm/need 1
hiifong
approved these changes
Jul 12, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21692
In parseCommitWithGPGSignature and parseCommitWithSSHSignature, we should not check the committer's emails again, because the committer is prepared by caller, the caller has already make sure the email is activated or is a no-reply email.