Skip to content

Add Notifications section in User Settings #35008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 11, 2025
Merged

Add Notifications section in User Settings #35008

merged 11 commits into from
Jul 11, 2025

Conversation

NorthRealm
Copy link
Contributor

@NorthRealm NorthRealm commented Jul 9, 2025 •
edited
Loading

image

Related: #34982

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jul 9, 2025
@NorthRealm NorthRealm mentioned this pull request Jul 9, 2025
Merged
@silverwind
Copy link
Member

I see where this is coming from as GitHub also has such a section. I wonder if we have more stuff to put into it than this single option.

@NorthRealm
Copy link
Contributor Author

NorthRealm commented Jul 9, 2025 •
edited
Loading

@silverwind Yes, I plan to put Actions email settings in it.

@lunny lunny added this to the 1.25.0 milestone Jul 9, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 9, 2025
@xuedi
Copy link

xuedi commented Jul 10, 2025

at work i get 4000+ emails daily, i never look into any of them, i just use the filters "review requested" and "Created by you" ... Its killing my postbox, and if i unfollow i don't get the bubble notification ...

Thanks a lot for this PR !!

@NorthRealm
Copy link
Contributor Author

@xuedi @lunny My current plan is:

  1. Add the new Notification section
  2. Merge it to Send email on Workflow Run Success/Failure #34982
  3. Add Actions email settings, add new table and migration.

@NorthRealm
Copy link
Contributor Author

@xuedi @lunny Presumably in future PRs, could drop current notification setting constants and create a set of fine-grained notification settings similar to GitHub's. Since lots focus on Issues, Pull Requests and Releases, probably won't be a difficult task. Can start from EmailNotificationsPreference reference in code and rewrite stuff.

@lunny
Copy link
Member

lunny commented Jul 10, 2025

Thank you. I also think this PR should be merged first.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 10, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 10, 2025
wxiaoguang
wxiaoguang reviewed Jul 10, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Jul 10, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Jul 10, 2025
View reviewed changes
NorthRealm and others added 2 commits July 11, 2025 00:53
@NorthRealm @wxiaoguang
UPDATE
5a7e9c1 
Co-authored-by: wxiaoguang <[email protected]>
Signed-off-by: NorthRealm <[email protected]>
@NorthRealm @wxiaoguang
UPDATE
06b0575 
Co-authored-by: wxiaoguang <[email protected]>
Signed-off-by: NorthRealm <[email protected]>
@wxiaoguang wxiaoguang removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 10, 2025
@wxiaoguang wxiaoguang merged commit 56eccb4 into go-gitea:main Jul 11, 2025
26 checks passed
@NorthRealm NorthRealm deleted the patch7 branch July 11, 2025 03:18
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 14, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
3f8c574 
* giteaofficial/main:
  Refactor view issue & comment list styles (go-gitea#35061)
  Fix user's sign email check (go-gitea#35045)
  [skip ci] Updated translations via Crowdin
  Fix incorrect comment diff hunk parsing, fix github asset ID nil panic (go-gitea#35046)
  Add Notifications section in User Settings (go-gitea#35008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
7 participants
@NorthRealm @silverwind @xuedi @lunny @wxiaoguang @hiifong @GiteaBot