Skip to content

Gitea version in Makefile #25456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silverwind merged 1 commit into from
Jun 23, 2023
Merged

Gitea version in Makefile #25456

silverwind merged 1 commit into from
Jun 23, 2023

Conversation

@jolheiser
Copy link
Member

@jolheiser jolheiser commented Jun 23, 2023

As title, this is how it was inferred before

gitea/Makefile

Lines 83 to 84 in e24f651

VERSION ?= $(subst v,,$(DRONE_TAG))
GITEA_VERSION ?= $(VERSION)

We moved to actions, however GITEA_VERSION should still work to use VERSION

@jolheiser jolheiser added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 23, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 23, 2023
@jolheiser jolheiser requested a review from techknowlogick June 23, 2023 02:19
@jolheiser jolheiser mentioned this pull request Jun 23, 2023
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 23, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 23, 2023
silverwind pushed a commit that referenced this pull request Jun 23, 2023
@jolheiser
Gitea version in Makefile (#25456) (#25457)
ec539b7 
Backport-ish of #25456

Signed-off-by: jolheiser <[email protected]>
@silverwind silverwind merged commit 2e65c22 into go-gitea:main Jun 23, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jun 23, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Milestone

1.21.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jolheiser @silverwind @delvh @GiteaBot