New Feature: you can choose a folder of photos as your background picture,it will change by time.#633
Open
Josh050608 wants to merge 2 commits intognachman:masterfrom
Open
New Feature: you can choose a folder of photos as your background picture,it will change by time.#633Josh050608 wants to merge 2 commits intognachman:masterfrom
Josh050608 wants to merge 2 commits intognachman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds a new background image source mode for profiles:
Folder Rotation.In
Settings > Profiles > Window > Background, profiles can now choose between:Single ImageFolder RotationWhen
Folder Rotationis selected, the profile can store:At runtime, sessions using the same profile share the same rotated background image.
What Changed
SourceFolderInterval (seconds)PTYSessionto resolve background images through the rotation manager when folder rotation is enabledBehavior
Manual Testing
Tested manually with a Development build:
Single Imagestill works as beforeFolder Rotationsettings save and reload correctlyDemo video
output.mp4