🐛 fix(context-menu): apply window appearance to pane hamburger menu#630
Open
kud wants to merge 1 commit intognachman:masterfrom
Open
🐛 fix(context-menu): apply window appearance to pane hamburger menu#630kud wants to merge 1 commit intognachman:masterfrom
kud wants to merge 1 commit intognachman:masterfrom
Conversation
The titleBarMenu method now applies window appearance styling to the pane hamburger menu, matching the behaviour of the tab right-click context menu. This ensures the minimal theme's dark appearance is properly respected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket
No ticket.
📄 Description
The pane hamburger menu (shown via
titleBarMenu) was not inheriting the window's dark/light appearance when using the minimal theme. This caused it to render incorrectly — e.g. appearing light-themed in a dark window.The fix calls
applyWindowAppearanceToMenu:on the menu returned bytitleBarMenu, identical to what already happens for the tab right-click context menu (lines 94, 102, 110 iniTermTextViewContextMenuHelper.m). One line of change.📽️ Screencast
No visual changes in terms of layout — the fix corrects a visual regression where the pane menu ignored the window appearance. A before/after screenshot would show the menu now rendering with the correct dark appearance in a minimal-theme dark window.
✅ How to Validate
🛠️ Developer Checklist