Skip to content

🐛 fix(context-menu): apply window appearance to pane hamburger menu#630

Open
kud wants to merge 1 commit intognachman:masterfrom
kud:fix/pane-menu-dark-mode
Open

🐛 fix(context-menu): apply window appearance to pane hamburger menu#630
kud wants to merge 1 commit intognachman:masterfrom
kud:fix/pane-menu-dark-mode

Conversation

@kud
Copy link
Copy Markdown
Contributor

@kud kud commented Mar 25, 2026

🎟️ Ticket

No ticket.

📄 Description

The pane hamburger menu (shown via titleBarMenu) was not inheriting the window's dark/light appearance when using the minimal theme. This caused it to render incorrectly — e.g. appearing light-themed in a dark window.

The fix calls applyWindowAppearanceToMenu: on the menu returned by titleBarMenu, identical to what already happens for the tab right-click context menu (lines 94, 102, 110 in iTermTextViewContextMenuHelper.m). One line of change.

📽️ Screencast

No visual changes in terms of layout — the fix corrects a visual regression where the pane menu ignored the window appearance. A before/after screenshot would show the menu now rendering with the correct dark appearance in a minimal-theme dark window.

✅ How to Validate

  1. Set iTerm2 theme to Minimal (Preferences → Appearance → Theme → Minimal).
  2. Set the colour scheme to a dark profile so the window is in dark mode.
  3. Open a pane and click the hamburger (≡) button in the title bar to open the pane menu.
  4. Confirm the menu respects the dark appearance (dark background, light text), matching the tab right-click context menu.
  5. Repeat with a light-mode window to confirm it also renders correctly in light mode.

🛠️ Developer Checklist

  • Code is readable and maintainable
  • Tests included and passing (if applicable)
  • PR is atomic and focused on a single feature or bug
  • Commits follow Conventional Commits

The titleBarMenu method now applies window appearance styling to the pane
hamburger menu, matching the behaviour of the tab right-click context menu.
This ensures the minimal theme's dark appearance is properly respected.
@kud kud marked this pull request as ready for review March 25, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant