Skip to content

Add button to resume individual plugins execution #19985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cedric-anne
Copy link
Member

@cedric-anne cedric-anne commented Jun 12, 2025

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

Add a "Resume plugin execution" button for "suspended" plugins, in both the classic plugin page and the marketplace page.

Handling the "suspended" state individualy is required to be able to implement the "Suspend all plugins execution" / "Resume all plugins execution" feature and to be able to set active plugins as "suspended" during the GLPI update instead of disabling them.

Screenshots (if appropriate):

Marketplace page:
image

Classic plugins page:
image

@orthagh
Copy link
Contributor

orthagh commented Jun 12, 2025

I understand the final purpose (GLPI update), but do we need UI for a single manual action?

@cedric-anne
Copy link
Member Author

I understand the final purpose (GLPI update), but do we need UI for a single manual action?

Individual action are not strictly required, but I guess it could help people to suspend/resume plugins one by one when they try to figure out which plugin is responsable of a specific behaviour/bug.

Anyway we need to display something in the plugin card to indicate when the plugin is suspended.

@orthagh
Copy link
Contributor

orthagh commented Jun 13, 2025

From a user perspective, the difference between paused and disabled will not be clear.
Question, apart from the update scenario, where do we need the paused state?
I suggest that when the plugin is paused to replace the enable/disable switch with a ti-pause icon button (we may switch to a ti-play on hover) with a tooltip indicating the plugin has been temporarily paused, and you can force resuming. When "resumed", you display the classic switch "disable/enable"

@cedric-anne
Copy link
Member Author

Question, apart from the update scenario, where do we need the paused state?

The support team asked many times to have a feature that permit to suspend/resume all the plugins execution at once, to be able to easilly check whether a plugin is responsible of a given bug/behaviour.

I suggest that when the plugin is paused to replace the enable/disable switch with a ti-pause icon button (we may switch to a ti-play on hover) with a tooltip indicating the plugin has been temporarily paused, and you can force resuming. When "resumed", you display the classic switch "disable/enable"

OK

@cedric-anne cedric-anne force-pushed the 11.0/suspend-resume-plugin-exec branch from 3689609 to c04a86b Compare June 16, 2025 07:57
@cedric-anne cedric-anne requested review from orthagh and removed request for orthagh June 16, 2025 07:57
@orthagh
Copy link
Contributor

orthagh commented Jun 16, 2025

suspend/resume all the plugins

I was against adding single buttons to the existing ones, but I'm still OK with a global action, in both UI and console. For the legacy list, a massive action should be ok. For the marketplace UI, a dedicated button will be required.

@cedric-anne cedric-anne changed the title Add buttons to suspend/resume individual plugins execution Add button to resume individual plugins execution Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants