[HLAPI] Forms #19899
Draft
[HLAPI] Forms #19899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Suggest this as a replacement of #19754 to avoid adding non-standard endpoints and behavior to the legacy API, especially for a feature that only ever existed in GLPI 11 after the new API was introduced. I'm not going to worry too much about application specific requirements here either. The new API gives applications so much more control over the data in both the REST portion of the API and especially in the GraphQL wrapper, so I don't see the need unless there is another property that needs mapped to be useful like I did with the
illustration->illustration_url.This PR will only focus on the bare minimum read-only access to Forms; not that adding endpoints and schemas to the new API is too complex to read but because I don't really have that much time to manage more big tasks currently. Subsequent PRs can expand on this.