Fix a bug in 'get-identities' text output#1277
Merged
Merged
Conversation
Globus Auth identity usernames are always lowercase. And identity IDs are 36-char represented UUIDs (meaning they are case insensitive). However, comparisons for text output printing were done without lowercasing or casefolding, resulting in incorrect failures to match on usernames like 'Abc@example.com' vs 'abc@example.com'. The behavior is fixed both for IDs and usernames, and a new test confirms simply that uppercased and lowercased inputs result in the same outputs. Additionally, some small type annotation fixes are made: a `str` was annotated incorrectly as a dict, and `typing.cast` was used where `isinstance` can provide a better runtime guarantee.
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
July 6, 2026 16:03
ada-globus
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Globus Auth identity usernames are always lowercase. And identity IDs are
36-char represented UUIDs (meaning they are case insensitive).
However, comparisons for text output printing were done without
lowercasing or casefolding, resulting in incorrect failures to match on
usernames like 'Abc@example.com' vs 'abc@example.com'.
The behavior is fixed both for IDs and usernames, and a new test confirms
simply that uppercased and lowercased inputs result in the same outputs.
Additionally, some small type annotation fixes are made: a
strwasannotated incorrectly as a dict, and
typing.castwas used whereisinstancecan provide a better runtime guarantee.