Open
Conversation
Owner
Author
|
cc @agargaro - awhile ago we discussed improving the performance of the "shapecast" function by allowing it to pass float32 "bounds array" rather than implicitly converting it a Box3 ahead of time. This PR makes (most of) the changes to achieve this with the "useBox3 = false" option. ClosestPointToPoint has been changed to use the bounds arrays but I'm not seeing any performance benefit compared to master. Is this along the lines of what you were thinking? |
Contributor
|
I would have expected a slight improvement, like with raycasting. I'll try running some tests locally later to understand more 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #656
Remaining Issues