-
Notifications
You must be signed in to change notification settings - Fork 72
Workflow enhancements #707
base: master
Are you sure you want to change the base?
Conversation
77a4847
to
4be2966
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, many thanks for adding a husky pre-commit hook and installing Prettier. ✨ This makes the project feel much cleaner and professional.
Unfortunately, this PR is a bit too big for me to seriously review it now (touches almost all blog posts and code files, and there are a few surprising changes mixed in like a new yarn.lock
).
Could you please split up the work? (And maybe do that after some of your other PRs are merged, because otherwise you're going to make conflicting changes on the same files.)
E.g. maybe first install Prettier, and the pre-commit hook, without refactoring the entire codebase? Then, after that's merged, we can see about refactoring reasonable chunks of the codebase carefully while keeping PRs at reviewable size?
@@ -12,21 +12,23 @@ vscode: | |||
- [email protected]:7hF8G3VtB+HNearI5Zw+NA== | |||
- [email protected]:YnjK47pXScU3DMFfQzkkOw== | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary extra empty line.
@jankeromnes Many Thanks. yeah splitting the work and waiting for other PRs to be merged would be better for everyone. Currently, this PR is really quite hard to review. Sorry, I should have thought about this before. I will make small PRs once my others PRs are merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that there's value in this pull-request but too much was changed. Needs to be a smaller increment.
This PR is aimed towards enhancing the overall code quality of the site.
format
, 'test` (which intern runs lint task).Edit
I have removed the
format
task from the pre-commit hook as format on saving is enabled with prettier extension being installed.