Skip to content

Add Ona banner notification #20908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

Add Ona banner notification #20908

merged 2 commits into from
Jun 17, 2025

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Jun 17, 2025 •
edited
Loading

Description

image

Related Issue(s)

Part of GRO-887

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@Siddhant-K-code
Add Ona banner notification with gradient background
98f5b7b 
- Replace Gitpod Classic sunset message with Ona introduction
- Add Ona wordmark SVG import and display
- Apply gradient background for Ona banner
- Set white text color and underlined link to https://ona.com/
- Link styling with hover effect (underline disappears on hover)
@Siddhant-K-code Siddhant-K-code requested review from a team as code owners June 17, 2025 11:50
@Siddhant-K-code
Copy link
Member Author

/unhold

corneliusludmann
corneliusludmann approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Approve to unblock.

Proposal for improvement: In my opinion, the "ONA" wordmark is not well aligned vertically. It does not sit on the same baseline as the rest of the text. WDYT?

@Siddhant-K-code
Copy link
Member Author

/hold

@Siddhant-K-code Siddhant-K-code marked this pull request as draft June 17, 2025 11:59
@Siddhant-K-code Siddhant-K-code marked this pull request as ready for review June 17, 2025 12:04
@Siddhant-K-code
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 2946c9a into main Jun 17, 2025
49 checks passed
@roboquat roboquat deleted the ona-banner branch June 17, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusludmann corneliusludmann corneliusludmann approved these changes

@filiptronicek filiptronicek filiptronicek approved these changes

Assignees
No one assigned
Labels
size/S team: team-enterprise team: team-experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Siddhant-K-code @corneliusludmann @filiptronicek @roboquat