feat(but): add sign-on-push functionality to but CLI#13000
Draft
feat(but): add sign-on-push functionality to but CLI#13000
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
bot
added
rust
slarse
force-pushed
the
GB-1121/sign-on-push-groundwork
branch
from
2ebe52b to
1af2176
Compare
slarse
force-pushed
the
GB-1121/sign-on-push-continued
branch
from
10d98b8 to
d384ab9
Compare
slarse
force-pushed
the
GB-1121/sign-on-push-groundwork
branch
from
1af2176 to
60ffe7c
Compare
slarse
force-pushed
the
GB-1121/sign-on-push-continued
branch
from
d384ab9 to
4118849
Compare
slarse
force-pushed
the
GB-1121/sign-on-push-groundwork
branch
from
60ffe7c to
e3a1aaa
Compare
slarse
force-pushed
the
GB-1121/sign-on-push-continued
branch
from
4118849 to
518c952
Compare
slarse
force-pushed
the
GB-1121/sign-on-push-groundwork
branch
from
e3a1aaa to
58dc1c0
Compare
slarse
force-pushed
the
GB-1121/sign-on-push-continued
branch
from
518c952 to
3e09e7a
Compare
This commit puts down the groundwork for enabling sign-on-push functionality. Importantly, it contributes but-workspace abstractions to list unsigned commits and forcibly sign commits, as well as the underlying graph rebase engine work to actually accomplish the signing. Note that there is still full backwards compatibility with the current sign-all-the-flippin-time functionality.
Adds in sign-on-push functionality, along with a new Git config setting to enable it. This is all backwards compatible with gitbutler.signCommits and will be invisible to end users for the time being, one has manually set signMode=OnPush in the config to enable the new behavior.
slarse
force-pushed
the
GB-1121/sign-on-push-groundwork
branch
from
58dc1c0 to
d905572
Compare
slarse
force-pushed
the
GB-1121/sign-on-push-continued
branch
from
3e09e7a to
2aaaf84
Compare
slarse
force-pushed
the
GB-1121/sign-on-push-groundwork
branch
10 times, most recently
from
cdf1046 to
3dfc22e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in sign-on-push functionality, along with a new Git config setting to enable it. This is all backwards compatible with gitbutler.signCommits and will be invisible to end users for the time being, one has manually set signMode=OnPush in the config to enable the new behavior.
The UX here is still a bit rough. The push command is overall a bit rough to work with and I think this needs some major refactor. Perhaps not in this PR but soon.
TODO
This is part 1 of 1 in a stack made with GitButler: