Fix type resolution issue in GL push constants#9116
Open
cwfitzgerald wants to merge 2 commits intogfx-rs:trunkfrom
Open
Fix type resolution issue in GL push constants#9116cwfitzgerald wants to merge 2 commits intogfx-rs:trunkfrom
cwfitzgerald wants to merge 2 commits intogfx-rs:trunkfrom
Conversation
cwfitzgerald
changed the title
inner-daemons
suggested changes
Feb 26, 2026
Collaborator
inner-daemons
left a comment
inner-daemons
left a comment
There was a problem hiding this comment.
Generally looks good, 2 nits.
Also, the tests go in regression but is this actually a regression, or just an issue we've had since forever?
Member
Author
|
Regression tests help prevent re-regressions. Does this fully make sense, dunno. But I've used the regression folder for "misc tests to prevent a given issue from coming back" |
cwfitzgerald
force-pushed
the
cw/regression-9115
branch
from
dc24be4 to
bae8fb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9115