Move Features::PRIMITIVE_INDEX into the WebGPU group #9101
Draft
andyleiserson wants to merge 4 commits intogfx-rs:trunkfrom
Draft
Move Features::PRIMITIVE_INDEX into the WebGPU group #9101andyleiserson wants to merge 4 commits intogfx-rs:trunkfrom
Features::PRIMITIVE_INDEX into the WebGPU group #9101andyleiserson wants to merge 4 commits intogfx-rs:trunkfrom
Conversation
inner-daemons
approved these changes
Feb 24, 2026
| /// This is a native only feature. | ||
| const SHADER_DRAW_INDEX = 1 << 59; | ||
|
|
||
| // Adding a new feature? Bit 35 (formerly SHADER_PRIMITIVE_INDEX) is available. |
Collaborator
There was a problem hiding this comment.
Free parking down the road 🗣
Comment on lines
1612
to
1616
| /// Supported platforms: | ||
| /// - Vulkan | ||
| /// - DX12 | ||
| /// - Metal (some) | ||
| /// - OpenGL (some) |
Collaborator
There was a problem hiding this comment.
FWIW if we are explicitly saying that not all devices on the API will support it, Vulkan should probably also be (some) since it needs geometry shader support. HLSL is fine because this was added in SM4 (DX10).
Contributor
Author
|
I've marked this as draft because the CTS failures in CI appear real, and I don't have time to debug them right now. #9105 is a failure related to |
fe52ea9 to
b7e8d43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
Features::SHADER_PRIMITIVE_INDEXtoFeatures::PRIMITIVE_INDEX(for consistency with the spec, which usesshader_f16but notshader_primitive_index), and moves it to the WebGPU feature set.Putting it in the WebGPU feature set results in it being exposed by Deno and available in CTS runs, so, enable the CTS tests for
primitive_index. I've also added acts_runnerintegration test that checks the feature is exposed, because the CTS silently skips the relevant tests if it is not.I've also reworded the changelog entry related to
enable primitive_index, but the actual functional change was in #8879.CC @inner-daemons
Squash or Rebase? Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.