Fix local_invocation_id and local_invocation_index handling#9099
Open
inner-daemons wants to merge 3 commits intogfx-rs:trunkfrom
Open
Fix local_invocation_id and local_invocation_index handling#9099inner-daemons wants to merge 3 commits intogfx-rs:trunkfrom
inner-daemons wants to merge 3 commits intogfx-rs:trunkfrom
Conversation
…, plus added __local_invocation_id to MSL's keyword list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Closes #8820
This is blocking #8752 and #8739, which I would rather not keep having to maintain. So speed would be appreciated here.
Description
Solves issue with builtins possibly being written multiple times in HLSL and MSL, and with naming conflicts when users name variables
__local_invocation_idor__local_invocation_index.Testing
Snapshots
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.