Skip to content

Upgrade wasm-bindgen#9093

Closed
evilpie wants to merge 1 commit intogfx-rs:trunkfrom
evilpie:upgrade-bindgen
Closed

Upgrade wasm-bindgen#9093
evilpie wants to merge 1 commit intogfx-rs:trunkfrom
evilpie:upgrade-bindgen

Conversation

@evilpie
Copy link
Contributor

@evilpie evilpie commented Feb 22, 2026

Connections

Description

It seems like just upgrading wasm-bindgen/js-sys/web-sys breaks the WGPU examples:

Uncaught (in promise) RuntimeError: unreachable executed
__wbg_finalize_init http://127.0.0.1:8000/webgl2.js:2039
__wbg_init http://127.0.0.1:8000/webgl2.js:2121
webgl2_bg.wasm:12106005:1

The question is if that is a problem with wasm-bindgen and should be reported upstream, or caused by the vendoring of WebGPU.

Testing

Squash or Rebase?

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@evilpie
Copy link
Contributor Author

evilpie commented Mar 5, 2026

The issue on the wasm-bindgen side was fixed.

@evilpie evilpie marked this pull request as ready for review March 5, 2026 21:54
cwfitzgerald
cwfitzgerald previously approved these changes Mar 6, 2026
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@cwfitzgerald
Copy link
Member

Actually wait, is there any reason to bump these? cargo.lock bumps should update them, as we don't have = dependencies

@cwfitzgerald cwfitzgerald dismissed their stale review March 6, 2026 01:15

Question

@evilpie
Copy link
Contributor Author

evilpie commented Mar 6, 2026

True, in fact Cargo.lock already has 0.2.144.

@evilpie evilpie closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants