Merged
Conversation
noituri
force-pushed
the
@noituri/fix-nv12-copy
branch
2 times, most recently
from
f78ec44 to
4110b7c
Compare
noituri
force-pushed
the
@noituri/fix-nv12-copy
branch
from
4110b7c to
437cfb3
Compare
Wumpf
requested changes
Feb 21, 2026
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
Change looks good to me! But ...
I can also add tests to wgpu-gpu if you want me to.
yes, this definitely needs a test! :)
noituri
force-pushed
the
@noituri/fix-nv12-copy
branch
from
437cfb3 to
f501bf7
Compare
Contributor
Author
|
I added the tests. The invalid copy usage is caught by vulkan validation layers |
noituri
force-pushed
the
@noituri/fix-nv12-copy
branch
from
f501bf7 to
9725225
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
None
Description
Texture to texture copy didn't account for multi-planar textures which resulted in artifacts on linux-vulkan (windows-vulkan seems unaffected for some reason) and panic on DX12.
Testing
I made a simple app which renders a moving triangle onto NV12 texture and displays it (run on windows (dx12/vulkan) and linux (vulkan)).
I can also add tests to
wgpu-gpuif you want me to.Squash or Rebase?
squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.