Enable FLOAT32_BLENDABLE on Metal, in Deno, and separate from filtering#9032
Enable FLOAT32_BLENDABLE on Metal, in Deno, and separate from filtering#9032andyleiserson merged 3 commits intogfx-rs:trunkfrom
FLOAT32_BLENDABLE on Metal, in Deno, and separate from filtering#9032Conversation
jimblandy
left a comment
There was a problem hiding this comment.
Do we need to update wgpu_core::Device::get_texture_format_features as well?
jimblandy
left a comment
There was a problem hiding this comment.
Other than the question I asked just above, this looks good to me.
|
@jimblandy: I posted #9103. 😀 |
Good question. I think it is okay. Initially I wanted to say that the logic in that function related to But regardless of |
590d1c2 to
c810992
Compare
|
nitpick: Let's try to keep the same order as the WebGPU spec. for features. I pushed c810992 to correct this. |
According to the Metal feature tables, this is always available.
I've also added it to the Deno bindings, and removed a check that conflated blendability with filterability, which I believe reflected a spec error that was fixed some time ago in gpuweb/gpuweb#3920.
Testing
The CTS test
webgpu:api,validation,render_pipeline,float32_blendable:*is already enabled. Since this is an optional feature, the CTS test will pass whether or not it is available. But with this change, subcases change from SKIP to PASS.Squash or Rebase? Squash
Checklist
CHANGELOG.mdentry.