Relax overly strict maxInterStageShaderVariables validation for fragment stage inputs
#8792
+25
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rVariables` directly, not `max_fragment_input_variables`
…or `maxInterStageShaderVariables` errors
…iable` migration
…ne,inter_stage:max_variables_count,input:*`
ErichDonGubler
added
type: bug
ErichDonGubler
changed the title
maxInterStageShaderVariables validationmaxInterStageShaderVariables validation for fragment stage inputs
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Dec 31, 2025
…9912e853893d502 r=#webgpu-reviewers! Notes: - Most changes in expected permanent outcomes are driven by migration of wgpu to the next `maxInterStageShaderVariables` limit, dropping the old `maxInterStageShaderComponents` limit. - Some of CTS' tests for this limit are actually incorrect, while wgpu is correct. I'm filing up (and have even landed in CTS upstream) some work to correct them. See [gpuweb/cts#4538](gpuweb/cts#4538) for more details. - CTS isn't entirely to blame; I did make one check for fragment built-in inputs too restrictive. This has been corrected with [wgpu#8792](gfx-rs/wgpu#8792). - I decided to roll a `spirv` upgrade into this: 0.3.0+sdk-1.3.268.0 → 0.3.0+sdk-1.4.309.0@git:89ce4d0e64c91b0635f617409dc57cb031749a39 …since it's only used by this, and most changes should go away after the `spirv` releases its current mainline history. Differential Revision: https://phabricator.services.mozilla.com/D277553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Thankfully, these issues are "only" too strict. None of these caused major issues with incorrect commands getting to platforms.
Testing
CTS paths have been added.
Squash or Rebase?
rebase plz
Checklist
CHANGELOG.mdentry.