Skip to content

feat(autofix): Track if autofix state is fetched through endpoint or elsewhere #93088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 10, 2025
Merged

feat(autofix): Track if autofix state is fetched through endpoint or elsewhere #93088

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4572f99
Bump setup check rate limit
roaga Jun 7, 2025
1f0fb5e
Track if UI is geting autofix state or other source
roaga Jun 8, 2025
81afd80
Fix tests
roaga Jun 8, 2025
61c3620
Merge branch 'master' into autofix/auto-coding
roaga Jun 9, 2025
2cc395c
Switch to frontend flag
roaga Jun 9, 2025
248845e
Fix typing
roaga Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/sentry/api/endpoints/group_ai_autofix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ def get(self, request: Request, group: Group) -> Response:
if not access_check_cache_value:
check_repo_access = True

autofix_state = get_autofix_state(group_id=group.id, check_repo_access=check_repo_access)
autofix_state = get_autofix_state(
group_id=group.id, check_repo_access=check_repo_access, is_user_fetching=True
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, with this, just opening an issue details page will stop a PR from being made right? To continue off my comment in the seer PR, maybe if I'm staring at the drawer it would be better to stop, but if I just glance at an issue and if I have this setting on would make more sense to still go to the PR.

Anyways not a strong opinion, feel free to push back

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will update this to set the "is_user_fetching" based on a flag from the frontend so it only is set to true while looking at the drawer


if check_repo_access:
cache.set(access_check_cache_key, True, timeout=60) # 1 minute timeout
Expand Down
9 changes: 9 additions & 0 deletions src/sentry/api/endpoints/group_autofix_setup_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from sentry.models.project import Project
from sentry.seer.seer_setup import get_seer_org_acknowledgement, get_seer_user_acknowledgement
from sentry.seer.signed_seer_api import sign_with_seer_secret
from sentry.types.ratelimit import RateLimit, RateLimitCategory

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -95,6 +96,14 @@ class GroupAutofixSetupCheck(GroupAiEndpoint):
"GET": ApiPublishStatus.EXPERIMENTAL,
}
owner = ApiOwner.ML_AI
enforce_rate_limit = True
rate_limits = {
"GET": {
RateLimitCategory.IP: RateLimit(limit=200, window=60, concurrent_limit=20),
RateLimitCategory.USER: RateLimit(limit=100, window=60, concurrent_limit=10),
RateLimitCategory.ORGANIZATION: RateLimit(limit=1000, window=60, concurrent_limit=100),
}
}

def get(self, request: Request, group: Group) -> Response:
"""
Expand Down
7 changes: 6 additions & 1 deletion src/sentry/autofix/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,19 @@ def get_autofix_repos_from_project_code_mappings(project: Project) -> list[dict]


def get_autofix_state(
*, group_id: int | None = None, run_id: int | None = None, check_repo_access: bool = False
*,
group_id: int | None = None,
run_id: int | None = None,
check_repo_access: bool = False,
is_user_fetching: bool = False,
) -> AutofixState | None:
path = "/v1/automation/autofix/state"
body = orjson.dumps(
{
"group_id": group_id,
"run_id": run_id,
"check_repo_access": check_repo_access,
"is_user_fetching": is_user_fetching,
}
)

Expand Down
24 changes: 17 additions & 7 deletions tests/sentry/api/endpoints/test_group_ai_autofix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ def test_ai_autofix_get_endpoint_with_autofix(
assert "profile" not in response.data["autofix"]["request"]
assert "issue_summary" not in response.data["autofix"]["request"]

mock_get_autofix_state.assert_called_once_with(group_id=group.id, check_repo_access=True)
mock_get_autofix_state.assert_called_once_with(
group_id=group.id, check_repo_access=True, is_user_fetching=True
)

@patch("sentry.api.endpoints.group_ai_autofix.get_autofix_state")
def test_ai_autofix_get_endpoint_without_autofix(
Expand All @@ -65,7 +67,9 @@ def test_ai_autofix_get_endpoint_without_autofix(
assert response.status_code == 200
assert response.data["autofix"] is None

mock_get_autofix_state.assert_called_once_with(group_id=group.id, check_repo_access=True)
mock_get_autofix_state.assert_called_once_with(
group_id=group.id, check_repo_access=True, is_user_fetching=True
)

@patch("sentry.api.endpoints.group_ai_autofix.get_autofix_state")
@patch("sentry.api.endpoints.group_ai_autofix.get_sorted_code_mapping_configs")
Expand Down Expand Up @@ -650,7 +654,7 @@ def test_ai_autofix_get_endpoint_cache_miss(
# Verify cache behavior - cache miss should trigger repo access check
mock_cache.get.assert_called_once_with(f"autofix_access_check:{self.group.id}")
mock_get_autofix_state.assert_called_once_with(
group_id=self.group.id, check_repo_access=True
group_id=self.group.id, check_repo_access=True, is_user_fetching=True
)

# Verify the cache was set with a 60-second timeout
Expand Down Expand Up @@ -681,7 +685,7 @@ def test_ai_autofix_get_endpoint_cache_hit(
# Verify cache behavior - cache hit should skip repo access check
mock_cache.get.assert_called_once_with(f"autofix_access_check:{self.group.id}")
mock_get_autofix_state.assert_called_once_with(
group_id=self.group.id, check_repo_access=False
group_id=self.group.id, check_repo_access=False, is_user_fetching=True
)

# Verify the cache was not set again
Expand Down Expand Up @@ -713,7 +717,9 @@ def test_ai_autofix_get_endpoint_polling_behavior(

# Verify first request behavior
mock_cache.get.assert_called_once_with(f"autofix_access_check:{group.id}")
mock_get_autofix_state.assert_called_once_with(group_id=group.id, check_repo_access=True)
mock_get_autofix_state.assert_called_once_with(
group_id=group.id, check_repo_access=True, is_user_fetching=True
)
mock_cache.set.assert_called_once_with(f"autofix_access_check:{group.id}", True, timeout=60)

# Reset mocks for second request
Expand All @@ -728,7 +734,9 @@ def test_ai_autofix_get_endpoint_polling_behavior(

# Verify second request behavior
mock_cache.get.assert_called_once_with(f"autofix_access_check:{group.id}")
mock_get_autofix_state.assert_called_once_with(group_id=group.id, check_repo_access=False)
mock_get_autofix_state.assert_called_once_with(
group_id=group.id, check_repo_access=False, is_user_fetching=True
)
mock_cache.set.assert_not_called()

# Reset mocks for third request
Expand All @@ -743,5 +751,7 @@ def test_ai_autofix_get_endpoint_polling_behavior(

# Verify third request behavior - should be like the first request
mock_cache.get.assert_called_once_with(f"autofix_access_check:{group.id}")
mock_get_autofix_state.assert_called_once_with(group_id=group.id, check_repo_access=True)
mock_get_autofix_state.assert_called_once_with(
group_id=group.id, check_repo_access=True, is_user_fetching=True
)
mock_cache.set.assert_called_once_with(f"autofix_access_check:{group.id}", True, timeout=60)
4 changes: 2 additions & 2 deletions tests/sentry/autofix/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def test_get_autofix_state_success_with_group_id(self, mock_post):

mock_post.assert_called_once_with(
f"{settings.SEER_AUTOFIX_URL}/v1/automation/autofix/state",
data=b'{"group_id":123,"run_id":null,"check_repo_access":false}',
data=b'{"group_id":123,"run_id":null,"check_repo_access":false,"is_user_fetching":false}',
headers={"content-type": "application/json;charset=utf-8"},
)

Expand Down Expand Up @@ -154,7 +154,7 @@ def test_get_autofix_state_success_with_run_id(self, mock_post):

mock_post.assert_called_once_with(
f"{settings.SEER_AUTOFIX_URL}/v1/automation/autofix/state",
data=b'{"group_id":null,"run_id":456,"check_repo_access":false}',
data=b'{"group_id":null,"run_id":456,"check_repo_access":false,"is_user_fetching":false}',
headers={"content-type": "application/json;charset=utf-8"},
)

Expand Down
Loading