Skip to content

fix(ui): Use consistent wording for API tokens #92991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanpurkhiser merged 1 commit into from
Jun 6, 2025
Merged

fix(ui): Use consistent wording for API tokens #92991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/views/settings/account/apiTokenRow.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe('ApiTokenRow', () => {
render(<ApiTokenRow onRemove={cb} token={ApiTokenFixture()} canEdit />);
renderGlobalModal();

await userEvent.click(screen.getByRole('button', {name: 'Remove'}));
await userEvent.click(screen.getByRole('button', {name: 'Revoke'}));
await userEvent.click(screen.getByRole('button', {name: 'Confirm'}));
expect(cb).toHaveBeenCalled();
});
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/settings/account/apiTokenRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function ApiTokenRow({
}
>
<Button size="sm" icon={<IconSubtract isCircled />}>
{t('Remove')}
{t('Revoke')}
</Button>
</Confirm>
</Actions>
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/settings/account/apiTokens.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe('ApiTokens', function () {

render(<ApiTokens />);
renderGlobalModal();
const removeButton = await screen.findByRole('button', {name: 'Remove'});
const removeButton = await screen.findByRole('button', {name: 'Revoke'});
expect(removeButton).toBeInTheDocument();
expect(deleteTokenMock).not.toHaveBeenCalled();

Expand Down
2 changes: 1 addition & 1 deletion static/app/views/settings/organizationDeveloperSettings/sentryApplicationDetails.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ describe('Sentry Application Details', function () {
renderComponent();
renderGlobalModal();
await screen.findByRole('button', {name: 'Save Changes'});
await userEvent.click(screen.getByRole('button', {name: 'Remove'}));
await userEvent.click(screen.getByRole('button', {name: 'Revoke'}));
// Confirm modal
await userEvent.click(screen.getByRole('button', {name: 'Confirm'}));
expect(
Expand Down
2 changes: 1 addition & 1 deletion static/gsAdmin/views/userDetails.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ describe('User Details', function () {

expect(await screen.findByText('test-username')).toBeInTheDocument();
expect(screen.getByText('[email protected]')).toBeInTheDocument();
expect(screen.getByText('Remove')).toBeInTheDocument();
expect(screen.getByText('Revoke')).toBeInTheDocument();
});
});
});
2 changes: 1 addition & 1 deletion tests/acceptance/test_organization_developer_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def test_remove_tokens_internal_app(self):

self.load_page(url)

self.browser.click('[aria-label="Remove"]')
self.browser.click('[aria-label="Revoke"]')
self.browser.click('[data-test-id="confirm-button"]')
self.browser.wait_until(".ref-success")

Expand Down
Loading