Skip to content

fix(attachments): Fix issue where attachment name would overflow off card #92990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelSun48 merged 5 commits into from
Jun 6, 2025
Merged

fix(attachments): Fix issue where attachment name would overflow off card #92990

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8ab084
Fix issue where attachment name would overflow off card
Jun 5, 2025
a286153
Split attachment name out of tooltip
Jun 6, 2025
a663180
Make delete button have danger priority
Jun 6, 2025
711ab5d
Make font bold again
Jun 6, 2025
79d4076
Remove redundant styles
Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions static/app/views/issueDetails/groupEventAttachments/screenshotCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,10 @@ export function ScreenshotCard({
return (
<StyledCard>
<CardHeader>
<div>
<AttachmentName>{eventAttachment.name}</AttachmentName>
<ScreenshotInfo>
<Tooltip title={eventAttachment.name} showOnlyOnOverflow skipWrapper>
<AttachmentName>{eventAttachment.name}</AttachmentName>
</Tooltip>
<div>
<DateTime date={eventAttachment.dateCreated} /> &middot;{' '}
<Link
Expand All @@ -94,7 +96,7 @@ export function ScreenshotCard({
</Tooltip>
</Link>
</div>
</div>
</ScreenshotInfo>
<DropdownMenu
items={[
{
Expand All @@ -115,6 +117,7 @@ export function ScreenshotCard({
confirmText: t('Delete'),
});
},
priority: 'danger',
},
]}
position="bottom-end"
Expand Down Expand Up @@ -155,24 +158,31 @@ export function ScreenshotCard({
);
}

const ScreenshotInfo = styled('div')`
display: flex;
flex-direction: column;
min-width: 0;
`;

const StyledCard = styled(Card)`
margin: 0;
padding: ${space(1)} ${space(1.5)};
`;

const AttachmentName = styled('div')`
font-weight: bold;
const AttachmentName = styled('span')`
display: flex;
font-weight: ${p => p.theme.fontWeightBold};
${p => p.theme.overflowEllipsis};
Copy link
Member

@evanpurkhiser evanpurkhiser Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait doens't overflowEllipsis give us some of these styles too?

Copy link
Contributor Author

@MichaelSun48 MichaelSun48 Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good point, the styles under this are redundant. removed

`;

const CardHeader = styled('div')`
display: flex;
justify-content: space-between;
padding: ${space(1.5)} ${space(1.5)} ${space(1.5)} ${space(2)};
padding-bottom: ${space(1)};
flex-shrink: 0;
`;

const CardBody = styled('div')`
background: ${p => p.theme.gray100};
padding: ${space(1)} ${space(1.5)};
max-height: 250px;
min-height: 250px;
overflow: hidden;
Expand All @@ -189,6 +199,7 @@ const StyledPanelBody = styled(PanelBody)`
align-items: center;
justify-content: center;
flex: 1;
border-radius: ${p => p.theme.borderRadius};
`;

const StyledLoadingIndicator = styled('div')`
Expand Down
Loading