fix(aci): Reduce deadlock risk in ActionGroupStatus updates #92451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
saponifi3d
approved these changes
May 28, 2025
kcons
added
Trigger: getsentry tests
|
PR reverted: bcf6cbc |
getsentry-bot
added a commit
that referenced
this pull request
May 29, 2025
…92451)" This reverts commit f5dce95. Co-authored-by: kcons <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
Order ActionGroupStatus updates to ensure consistent row locking order across concurrent executions, potentially avoiding deadlocks. Also limit updates to where date_updated is actually newer, which could theoretically reduce overlap between concurrent update queries. See SENTRY-3WEA.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
…92451)" This reverts commit f5dce95. Co-authored-by: kcons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order ActionGroupStatus updates to ensure consistent row locking order across concurrent executions, potentially avoiding deadlocks.
Also limit updates to where date_updated is actually newer, which could theoretically reduce overlap between concurrent update queries.
See SENTRY-3WEA.