feat(searchbar): Add tooltip descriptions to filter keys #92449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a tooltip to each filter key.
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92449 +/- ##
==========================================
+ Coverage 87.89% 87.92% +0.03%
==========================================
Files 10239 10226 -13
Lines 587415 585225 -2190
Branches 22809 22678 -131
==========================================
- Hits 516311 514585 -1726
+ Misses 70674 70218 -456
+ Partials 430 422 -8 |
malwilley
reviewed
May 28, 2025
static/app/components/searchQueryBuilder/tokens/filterKeyListBox/utils.tsx
Outdated
Show resolved
Hide resolved
static/app/components/searchQueryBuilder/tokens/filter/filterOperator.tsx
Outdated
Show resolved
Hide resolved
malwilley
approved these changes
May 30, 2025
| if (!includeKeyLabel) { | ||
| return <OpLabel>{opLabel}</OpLabel>; | ||
| } | ||
|
|
||
| return ( | ||
| <KeyOpLabelWrapper> | ||
| <span>{keyLabel}</span> | ||
| <Tooltip title={fieldDefinition?.desc} skipWrapper> |
There was a problem hiding this comment.
Is it possible to wrap this tooltip around the whole thing? For is not it looks like it only gets wrapped around is. Kind of an edge case though
# Conflicts: # static/app/utils/fields/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a tooltip to each filter key.
fixes https://linear.app/getsentry/issue/RTC-862/mouseover-of-search-attributes-should-show-the-schema-info