ref(aci): group data condition choices #92438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
May 29, 2025
| { | ||
| key: DataConditionHandlerSubgroupType.FREQUENCY, | ||
| label: t('Filter by Frequency'), | ||
| options: Array.from(new Set(frequencyOptions)), |
There was a problem hiding this comment.
could maybe just have frequencyOptions as a set
There was a problem hiding this comment.
oh i forgot to remove this-- this didn't work since i think the options are compared by reference, so none of the duplicates were actually removed
scttcper
reviewed
May 29, 2025
static/app/views/automations/components/dataConditionNodeList.tsx
Outdated
Show resolved
Hide resolved
scttcper
reviewed
May 29, 2025
scttcper
approved these changes
May 29, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
updated dataConditionNodeList to use response data from the data conditions endpoint + added grouping by handler subgroup had to add special logic for the frequency conditions that have additional branching to determine whether to use count/percent frequency so that we don't list those conditions twice <img width="911" alt="Screenshot 2025-05-28 at 1 10 36 PM" src="https://github.com/user-attachments/assets/d23b8a8e-40da-4bd6-96d6-72b0cad1aa18" /> example of branching frequency condition, for reference: <img width="555" alt="Screenshot 2025-05-28 at 1 15 09 PM" src="https://github.com/user-attachments/assets/9180d78a-d59a-44dd-b067-031a1c0f1f5a" />
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated dataConditionNodeList to use response data from the data conditions endpoint + added grouping by handler subgroup
had to add special logic for the frequency conditions that have additional branching to determine whether to use count/percent frequency so that we don't list those conditions twice
example of branching frequency condition, for reference:
