fix random range for stock index #161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
'randInRange(..)' is supposed to be inclusive of the upper range. |
|
Opened a new PR regarding the randInRange upper bound. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In chapter 9 demo project, you use a function randInRange to return a random stock index.
As The upper bound, you send stockIds.length - 1, though the upper bound is exclusive.
I changed it to stockIds.length.
### Note: Currently this small bug presents no symptoms, coincidentally, due to another bug (See #160) that adds a redundant item to the array.
After the fix presented in #160, the last stock never receive any updates.