Add new locator schema templates://#3059
Open
NicoHood wants to merge 1 commit intogetgrav:developfrom
Open
Conversation
Member
|
what is the compelling reason for this? |
Contributor
Author
|
The reason for adding the docs or adding
For example: // Check if a template exists for the given data
$template = 'structured-data/json-ld/' . $key . '/' . $key . '.json.twig';
if ($locator->findResource('templates://' . $template, true, false) === false) {
continue;
}
$this->grav['twig']->processTemplate($template);
[...] |
Member
|
It won't work. The reason is that twig isn't using a stream and paths can be added later, too. |
Contributor
Author
|
I dont understand, it works for me. And the event to add path is run first, so all templates should be in place. But I am no expert here, however I've need a solution to lookup the templates from a plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also see getgrav/grav-learn#851