Skip to content

Conversation

cookiedan42
Copy link
Contributor

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Simplification of Contains in the opposite direction of #1427 , Covers trait allows for simpler Geom in Geom operations because we don't need to be concerned about rhs being inside self's boundary

Parts implemented

  1. New Covers Trait
  2. Blanket implementation based on Relate
  3. Results which can be derived from intersects
  4. Some results which are equivalent to Contains
  5. enable jts-tests-runner case for Covers

lacking in the test department, but these are the basic derivable implementations

@cookiedan42
Copy link
Contributor Author

Bench

Big leap over Contains delegated to Relate

rect covers line        time:   [949.68 ps 951.09 ps 952.49 ps]
                        change: [-1.8060% -1.4820% -1.1652%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
  2 (2.00%) low severe
  5 (5.00%) low mild
  2 (2.00%) high severe

rect contains line      time:   [2.4912 µs 2.5091 µs 2.5262 µs]
                        change: [-1.7329% -1.1366% -0.5625%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant