Update crypto::capi for Win11 22H2, 23H2, 24H2 #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Author
|
Turns out later revisions of 24H2 have changed how CPExportKey operates quite a lot. No more comparison with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
The
rsaenh.dllfiles in Windows 11 22H2 to 24H2 (latest at the time of this PR) have gone back to the old pattern from Windows XP for the first patched check inCPExportKey:Currently,
crypto::capifails on these Windows versions. This PR brings compatibility for recent Win 11s, allowing to export private keys stored in theMicrosoft RSA SChannel Cryptographic Provider.Cheers !