Ch4 nodejs Fixes - remove remi repo config #413
+2
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Remi Repo tasks from Playbook. Remi repo does not contain npm or any of the required RPMs. Added version to package.json to fix bug that existed in version 3.3.0-3.3.1 of community.general.npm module.
|
Honestly I don't remember why I had the remi tasks in there... |
|
Hmm. I see the one that failed is getting the same error as I was getting, which is caused by not using 3.3.2+ of community.general.npm I can't see what role you're applying to download that Galaxy package, but it likely needs updating there first. |
Triggering CI.
geerlingguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Remi Repo tasks from Playbook. The CentOS 7/8 Repo does not contain npm or any of the required RPMs see here. EPEL 7 contains an npm package (3.10.0) but EPEL 8 does not because nodejs 10 and 12 LTS is available in the built-in AppStream repos.
Added version to package.json to fix bug that existed in version 3.3.0-3.3.1 of community.general.npm module. It would fail if a version tag was not available. This was fixed in 3.3.2, but should be there since it's included in the simple npminit values. See commit here