Conversation
These change adds Windows support to the Pepperoni App Kit.
chadrien
left a comment
chadrien
left a comment
There was a problem hiding this comment.
The docs part looks good 👍
If someone having a windows PC could try and see if it works, that would be great 🙂
| @@ -0,0 +1,9 @@ | |||
| { | |||
There was a problem hiding this comment.
Looks like the vscode configuration file to get javascript intellisense, not sure it should be there. Was it committed on purpose?
There was a problem hiding this comment.
No, forgot to remove it...will remove it.
|
@anidel thanks for submitting the PR :) Could you rebase on master and resolve the current conflicts before we merge it in? Would also still need to test it properly. |
tino-junge
left a comment
tino-junge
left a comment
There was a problem hiding this comment.
Reviewed now again and tested the app on windows. It would be great if we could add a travis build config as well for UWP. 2 issues I found so far:
- the app doesn't build because of a bug in react-native-windows 41
ReactTextShadowNode.cs:234
I fixed it by replacing it with the following:
textBlock.FontFamily = _fontFamily != null ? new FontFamily(_fontFamily) : new FontFamily("XamlAutoFontFamily”);
- vector icons are not yet displayed correctly. Might have to be added to build path?
3 participants
Relates to #63