Remove unreachable null check from toQueryParams fallthrough case

[Copilot]

The _ catch-all in toQueryParams contained a dead null branch that could never execute, due to a misunderstanding of how F# routes null through pattern matching.

Root cause

F# treats null as None for reference-type options at the .NET level (e.g., box (Option<string>.None) = null). When pattern matching against obj, F# binds null to the first matching | :? Option<T> as x -> arm — so null is correctly handled as None and returns [] via toStrOpt, never reaching _.

The original _ case:

| _ -> [ name, (if isNull obj then null else obj.ToString()) ]

...had a null branch returning [ (name, null) ] that was unreachable. Adding an explicit | null -> pattern after the option arms would produce compiler warning FS0026: This rule will never be matched.

Change

Simplified the fallthrough to remove the dead null check:

| _ -> [ name, obj.ToString() ]

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[Copilot]

Pull request overview

This PR simplifies query-parameter serialization in RuntimeHelpers.toQueryParams by removing an unreachable null check from the catch-all pattern, based on how null is handled earlier in the match.

Changes:

• Simplified the _ fallthrough case in toQueryParams to call obj.ToString() directly.
• Removed the dead isNull obj branch that could not be executed.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.