-
-
Notifications
You must be signed in to change notification settings - Fork 67
Translations update from Hosted Weblate #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughUpdated translation JSONs for spook_inverse: Finnish, Norwegian (nb_NO), Slovak, Danish, added Ukrainian, and a new empty Vietnamese file. Changes are limited to string content, reformatting, and minor field-ordering — no code, API, or data-structure changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
custom_components/spook/integrations/spook_inverse/translations/fi.json(3 hunks)custom_components/spook/integrations/spook_inverse/translations/nb_NO.json(2 hunks)custom_components/spook/integrations/spook_inverse/translations/sk.json(1 hunks)
🔇 Additional comments (2)
custom_components/spook/integrations/spook_inverse/translations/nb_NO.json (1)
7-22: LGTM on the Norwegian updatesVocabulary now consistently uses “Kildeentitet”, and the helper description reads naturally. No further action needed.
custom_components/spook/integrations/spook_inverse/translations/fi.json (1)
6-44: Finnish wording looks goodHyphenation (“Lähde-entiteetti”) and the refreshed description align with the English source and stay idiomatic.
| "menu_options": { | ||
| "switch": "Inverse prepínač", | ||
| "binary_sensor": "Inverse a binárne senzor" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the Slovak binary sensor label
The string now reads “Inverse a binárne senzor”, which mixes the English article “a” with Slovak grammar and degrades clarity. Please drop the stray article (e.g., “Inverse binárny senzor”) so the label is correct for Slovak speakers.
- "binary_sensor": "Inverse a binárne senzor"
+ "binary_sensor": "Inverse binárny senzor"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "menu_options": { | |
| "switch": "Inverse prepínač", | |
| "binary_sensor": "Inverse a binárne senzor" | |
| }, | |
| "menu_options": { | |
| "switch": "Inverse prepínač", | |
| "binary_sensor": "Inverse binárny senzor" | |
| }, |
🤖 Prompt for AI Agents
In custom_components/spook/integrations/spook_inverse/translations/sk.json
around lines 21 to 24, the Slovak label "Inverse a binárne senzor" wrongly
includes the English article "a" and incorrect adjective/noun agreement; replace
that value with "Inverse binárny senzor" so the article is removed and the
adjective agrees with the masculine noun, preserving the existing JSON structure
and punctuation.
ceabcbe to
3564b47
Compare
|
3564b47 to
cec8183
Compare
Currently translated at 100.0% (21 of 21 strings) Translation: Spook/Inverse helper Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/sk/
Currently translated at 100.0% (21 of 21 strings) Translation: Spook/Inverse helper Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/nb_NO/
Currently translated at 100.0% (21 of 21 strings) Translation: Spook/Inverse helper Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/fi/
Currently translated at 100.0% (21 of 21 strings) Translation: Spook/Inverse helper Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/da/
Currently translated at 100.0% (21 of 21 strings) Translation: Spook/Inverse helper Translate-URL: https://hosted.weblate.org/projects/spook/inverse-helper/uk/
cec8183 to
53a7c37
Compare
|



Translations update from Hosted Weblate for Spook/Inverse helper.
Current translation status: