Skip to content

feat: wrap user-facing strings with __() in src2 for i18n#927

Merged
nextchamp-saqib merged 5 commits intodevelopfrom
copilot/translate-user-facing-strings
Mar 13, 2026
Merged

feat: wrap user-facing strings with __() in src2 for i18n#927
nextchamp-saqib merged 5 commits intodevelopfrom
copilot/translate-user-facing-strings

Conversation

Copy link
Contributor

Copilot AI commented Mar 13, 2026

Extends translation coverage to all user-facing strings in frontend/src2, following the pattern established in #926. Every label, title, message, placeholder, and description visible to users is now routed through the __() translation function.

Scope

  • 72 files modified across query/, charts/, dashboard/, workbook/, settings/, users/, teams/, data_source/, data_store/, and helpers/
  • Covers .vue templates and .ts logic files (toast messages, confirm dialogs, dropdown options, list column headers, empty states, validation errors)

Pattern

// Before
label: 'Sort Ascending'
title: 'Download Failed'
message: `File "${filename}" exported successfully`

// After
import { __ } from '../translation'

label: __('Sort Ascending')
title: __('Download Failed')
message: __('File "{0}" exported successfully', filename)

Dynamic interpolation uses {0}, {1} etc. as positional placeholders, consistent with the translate() implementation in translation.ts.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits March 13, 2026 12:22
Co-authored-by: nextchamp-saqib <25369014+nextchamp-saqib@users.noreply.github.com>
Co-authored-by: nextchamp-saqib <25369014+nextchamp-saqib@users.noreply.github.com>
Copilot AI changed the title [WIP] Translate user facing strings using __() function feat: wrap user-facing strings with __() in src2 for i18n Mar 13, 2026
Copilot AI requested a review from nextchamp-saqib March 13, 2026 12:27
@nextchamp-saqib
Copy link
Member

@copilot run pre commit and fix formatting issues in the files changed

Eg. pre-commit run --show-diff-on-failure --color=always --from-ref 3ca6479f0f213753dec696c4a000abe39c08e61f --to-ref 1a8355789cbfbdaf02c90efe318e3ae046934850

Copilot AI and others added 2 commits March 13, 2026 12:38
Co-authored-by: nextchamp-saqib <25369014+nextchamp-saqib@users.noreply.github.com>
Co-authored-by: nextchamp-saqib <25369014+nextchamp-saqib@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 13, 2026

@copilot run pre commit and fix formatting issues in the files changed

Eg. ```pre-commit run --show-diff-on-failure --color=always --from-ref 3ca6479...

Fixed in ccae80b and 7708428. Pre-commit now passes cleanly — trailing whitespace and prettier formatting issues have been resolved across all changed files, and a Vue syntax error in SourceSelectorDialog.vue (title=__(...):title="__(...)" ) was also corrected.

@nextchamp-saqib nextchamp-saqib marked this pull request as ready for review March 13, 2026 12:52
@nextchamp-saqib nextchamp-saqib merged commit 3144968 into develop Mar 13, 2026
2 of 4 checks passed
@mergify mergify bot deleted the copilot/translate-user-facing-strings branch March 13, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants