Skip to content

fix: correct loading indicator placement in DataTable component (backport #1078) #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mergify wants to merge 1 commit into
base: version-3-hotfix
Choose a base branch
from
Open

fix: correct loading indicator placement in DataTable component (backport #1078) #1079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions frontend/src2/components/DataTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,17 +788,17 @@ function toggleNewColumn() {
</slot>
</div>

<div
v-else-if="props.loading && !props.filtering"
class="absolute top-10 flex h-[calc(100%-2.5rem)] rounded-b w-full items-center justify-center bg-white/30 backdrop-blur-sm"
>
<LoadingIndicator class="h-5 w-5 text-gray-500" />
</div>

<div v-else class="flex h-full w-full items-center justify-center">
<div class="flex flex-col items-center gap-2">
<Table2Icon class="h-16 w-16 text-gray-300" stroke-width="1.5" />
<p class="text-center text-gray-500">No data to display.</p>
</div>
</div>

<div
v-if="props.loading && !props.filtering"
class="absolute top-10 flex h-[calc(100%-2.5rem)] rounded-b w-full items-center justify-center bg-white/30 backdrop-blur-sm"
>
<LoadingIndicator class="h-5 w-5 text-gray-500" />
</div>
</template>
Loading