Skip to content

fix: disable statement timeout for long-running import jobs (backport #1072) #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mergify wants to merge 1 commit into
base: version-3-hotfix
Choose a base branch
from
Open

fix: disable statement timeout for long-running import jobs (backport #1072) #1074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions insights/insights/doctype/insights_data_source_v3/data_warehouse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,21 @@ def prepare_settings(self) -> dict:
commit=True,
)

def _disable_statement_timeout(self):
"""Disable statement timeout on the remote connection.

Import jobs are long-running background tasks managed by the queue
worker, so the user-facing max_execution_time limit should not apply.
"""
backend = insights.db_connections.get(self.table.data_source)
if backend is None:
return
with suppress(Exception):
backend.raw_sql("SET MAX_STATEMENT_TIME=0")

def prepare_remote_table(self) -> Expr:
self.remote_table = self.table.get_remote_table()
self._disable_statement_timeout()

if hasattr(self.remote_table, "creation"):
self.primary_key = "creation"
Expand Down