Revert "fix: fetch holiday list of an employee based on month end date filter… (backport #4199)"

[asmitahase]

Reverts #4215

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Updated holiday list resolution for employees to remove explicit date constraints during lookup, enabling more flexible holiday data retrieval.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c103cf1f-ae45-4058-9409-526d6a40d292

📥 Commits

Reviewing files that changed from the base of the PR and between ca25a52 and 301ea79.

📒 Files selected for processing (1)

• hrms/api/roster.py

---

Walkthrough

The get_holidays function in hrms/api/roster.py was modified by removing the as_on=month_end argument from the get_holiday_list_for_employee function call. The call now passes only the employee parameter and raise_exception=False. This removes the explicit date constraint previously applied when resolving the holiday list for an employee. The surrounding control flow and logic remain unchanged.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the primary change: reverting a previous fix related to holiday list fetching. It is specific, clear, and directly related to the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[frappe-pr-bot]

🎉 This PR is included in version 15.58.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀