Skip to content

fix: restrict API for pwa to fetch current logged-in employee only (backport #4207)#4213

Merged
asmitahase merged 4 commits intoversion-15-hotfixfrom
mergify/bp/version-15-hotfix/pr-4207
Mar 12, 2026
Merged

fix: restrict API for pwa to fetch current logged-in employee only (backport #4207)#4213
asmitahase merged 4 commits intoversion-15-hotfixfrom
mergify/bp/version-15-hotfix/pr-4207

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 11, 2026

Summary by CodeRabbit

  • Refactor
    • Centralized employee context resolution across attendance, shifts, leave balance, expense claims, and advance features
    • API endpoints now automatically determine the current employee instead of requiring explicit parameters from frontend requests
    • Enhanced consistency and maintainability of employee-scoped data retrieval

This is an automatic backport of pull request #4207 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from ruchamahabal as a code owner March 11, 2026 10:18
@mergify mergify bot added the conflicts label Mar 11, 2026
@mergify mergify bot added the conflicts label Mar 11, 2026
@mergify
Copy link
Contributor Author

mergify bot commented Mar 11, 2026

Cherry-pick of 1848d34 has failed:

On branch mergify/bp/version-15-hotfix/pr-4207
Your branch is up to date with 'origin/version-15-hotfix'.

You are currently cherry-picking commit 1848d343c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/api/__init__.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@asmitahase
Copy link
Member

This is gonna need manual cherry picking

…_employee_advance_balance, get_attendance_calendar_events

(cherry picked from commit 6791d95)
(cherry picked from commit 1848d34)
@asmitahase asmitahase force-pushed the mergify/bp/version-15-hotfix/pr-4207 branch from 99dcf0f to e27eeca Compare March 12, 2026 04:47
@asmitahase asmitahase merged commit ca25a52 into version-15-hotfix Mar 12, 2026
7 checks passed
@asmitahase asmitahase deleted the mergify/bp/version-15-hotfix/pr-4207 branch March 12, 2026 05:05
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.58.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants