Skip to content

fix: sync translations from crowdin#4201

Merged
asmitahase merged 1 commit intodevelopfrom
l10n_develop
Mar 6, 2026
Merged

fix: sync translations from crowdin#4201
asmitahase merged 1 commit intodevelopfrom
l10n_develop

Conversation

@frappe-pr-bot
Copy link
Collaborator

@frappe-pr-bot frappe-pr-bot commented Mar 6, 2026

Summary by CodeRabbit

  • Localization
    • Updated Serbian translation file references and metadata to synchronize with recent source code changes.
    • Added new translation entry for "Exemption Submission Proof" in the workspace sidebar.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

Walkthrough

This pull request updates the Serbian translation file (hrms/locale/sr.po) with adjustments to source code reference mappings and translation entries. The changes include updated line number anchors throughout the file reflecting shifts in source file positions (e.g., expense_claim.py:148 to expense_claim.py:149), reordering of existing translation message entries, and the addition of a new translation key for "Exemption Submission Proof" with an empty translation value. These modifications primarily consist of metadata and organizational adjustments rather than alterations to the translation strings themselves.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: sync translations from crowdin' accurately reflects the main change in the PR, which is synchronizing Serbian translations from Crowdin with adjustments to line references and a new translation entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@hrms/locale/sr.po`:
- Around line 3778-3781: In hrms/locale/sr.po update the empty msgstr for msgid
"Exemption Submission Proof" to the approved Serbian translation; replace the
blank msgstr with "Dokaz o podnošenju zahteva za oslobođenje" so it matches the
nearby tax-exemption proof terminology and appears correctly in the Serbian
workspace sidebar.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 205f41b2-27a2-432e-a4a3-c08dba116100

📥 Commits

Reviewing files that changed from the base of the PR and between 9301ccf and 9ba5f35.

📒 Files selected for processing (1)
  • hrms/locale/sr.po

Comment on lines +3778 to +3781
#. Label of a Workspace Sidebar Item
#: hrms/workspace_sidebar/tax_&_benefits.json
msgid "Exemption Submission Proof"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add the missing Serbian translation for this new sidebar item.

Line 3781 leaves msgstr empty for Exemption Submission Proof, so this entry will fall back to English in the Serbian workspace sidebar. Please populate it with the approved Serbian term, ideally matching the nearby tax-exemption proof terminology.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@hrms/locale/sr.po` around lines 3778 - 3781, In hrms/locale/sr.po update the
empty msgstr for msgid "Exemption Submission Proof" to the approved Serbian
translation; replace the blank msgstr with "Dokaz o podnošenju zahteva za
oslobođenje" so it matches the nearby tax-exemption proof terminology and
appears correctly in the Serbian workspace sidebar.

@asmitahase asmitahase merged commit 9479a67 into develop Mar 6, 2026
6 checks passed
@asmitahase asmitahase deleted the l10n_develop branch March 6, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants