Initialize the route change enum correctly #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blwinters
force-pushed
the
fix/audio-noisy
branch
from
9ac4996 to
498a625
Compare
blwinters
force-pushed
the
fix/audio-noisy
branch
from
498a625 to
30ee3cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses these issues:
onAudioBecomingNoisynot called on iOS TheWidlarzGroup/react-native-video#4295The
onVideoAudioBecomingNoisyhandler wasn't being called becuase this line resulted inreason: nil.The correct way to get the
AVAudioSession.RouteChangeReasonis to initialize it with the raw value provided byuserInfo, as confirmed by Apple documentation.I've confirmed with print statements that the
reasonis no longer nil and the handler is called when headphones are unplugged during playback.I also updated the commented-out line for consistency. I'll submit a PR to the original repo once this is tested and approved for our fork.
Testing
Connect a physical iPhone to Xcode via wifi and plug in USB-C headphones to the iPhone. In package.json for Floatplane, change the source branch for this package to match this PR's branch, then do a clean install of dependencies. Once installed, build and run the app on your iPhone via Xcode.