Generating sorting subroutines specific to character type with fypp
#475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awvwgk
approved these changes
Jul 31, 2021
gareth-nx
approved these changes
Aug 21, 2021
|
@gareth-nx Thank you for your review. I believed I answered all your comments. |
|
@jvdp1 Thanks for the changes. If anyone with commit rights has time to assist, note this patch seems very straightforward (it is only code simplification) and has been reviewed twice -- but we need another reviewer with commit rights to move it forward. @milancurcic @ivan-pi |
|
@milancurcic @ivan-pi @LKedward Could one of you review this PR, and merge it if you agree with it, please? |
|
With two approvals this patch is ready to go. I'll go ahead and merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all sorting subroutines for
integer,real, andstringwere generated withfypp.characterhad its own subroutines.I noticed that some checks were not present in
character-based subroutines, while present for other types. Therefore, I modified the fypp instructions, such that the sorting subrotuines are generated from a same template forinteger,real,string, andcharacter.With this strategy, if someone implements a derived type associated with
>,<,==,...., the sorting subroutines can be easily implemented for this DT by modifying only the fypp instructions.Additional reviewer: @wclodius2