feat: sobject refresh performance and progress indicator W-21240055

.claude/skills/concise/SKILL.md

@@ -1,14 +1,14 @@
 ---
 name: concise
-description: when creating/modifying md files (plans) in skills/rules for AI
+description: Writing style for AI-consumed docs. Proactively apply when creating or editing any md file in .claude/skills/ or .claude/rules/ or .cursor/rules/.
 disable-model-invocation: false
 ---
 
 # Concise
 
-We want to save tokens and preserve context window size.
+Save tokens and preserve context window.
 
-- use fragments/bullets, not full sentences
-- remove as many words as possible without altering meaning
+- fragments/bullets, not full sentences
+- remove words without altering meaning
 - cut repetition
-- prefer shorter words that mean the same thing
+- prefer shorter synonyms

.claude/skills/services-extension-consumption/SKILL.md

@@ -25,6 +25,22 @@ const ExtensionProviderServiceLive = Layer.effect(
 const api = yield * (yield * ExtensionProviderService).getServicesApi;
 ```
 
+## Prebuilt vs Per-Extension Services
+
+`api.services.prebuiltServicesDependencies` — pre-built `Context.Context` from services extension activation. Wrap with `Layer.succeedContext(...)`.
+
+Shares singleton instances (caches, watchers) across extensions; avoids re-building stateful services.
+
+Per-extension layers (must build yourself):
+
+| Layer | Why |
+|---|---|
+| `ChannelServiceLayer(displayName)` | Own output channel |
+| `ErrorHandlerService.Default` | Depends on own ChannelService |
+| `ExtensionContextServiceLayer(context)` | Own `ExtensionContext` |
+| `SdkLayerFor(context)` | Own tracer (extension name/version in resource attributes) |
+| `ExtensionProviderServiceLive` | Local singleton |
+
 ## ExtensionContext Setup
 
 Factory function building services layer with ExtensionContext:
@@ -35,21 +51,18 @@ export const buildAllServicesLayer = (context: ExtensionContext) =>
     Effect.gen(function* () {
       const extensionProvider = yield* ExtensionProviderService;
       const api = yield* extensionProvider.getServicesApi;
-      const extension = vscode.extensions.getExtension(`salesforce.${EXTENSION_NAME}`);
-      const extensionVersion = extension?.packageJSON?.version ?? 'unknown';
-      const o11yEndpoint = process.env.O11Y_ENDPOINT ?? extension?.packageJSON?.o11yUploadEndpoint;
-
-      // ErrorHandlerService needs ChannelService
-      const channelLayer = api.services.ChannelServiceLayer(extension?.packageJSON.displayName);
+      const channelLayer = api.services.ChannelServiceLayer(
+        context.extension.packageJSON.displayName ?? 'My Extension'
+      );
       const errorHandlerWithChannel = Layer.provide(api.services.ErrorHandlerService.Default, channelLayer);
 
       return Layer.mergeAll(
+        Layer.succeedContext(api.services.prebuiltServicesDependencies),
         ExtensionProviderServiceLive,
+        errorHandlerWithChannel,
         api.services.ExtensionContextServiceLayer(context),
-        api.services.sdkLayerFor(context)
-        // ... other services
-        channelLayer,
-        errorHandlerWithChannel
+        api.services.SdkLayerFor(context),
+        channelLayer
       );
     }).pipe(Effect.provide(ExtensionProviderServiceLive))
   );
@@ -175,25 +188,18 @@ export const buildAllServicesLayer = (context: ExtensionContext) =>
     Effect.gen(function* () {
       const extensionProvider = yield* ExtensionProviderService;
       const api = yield* extensionProvider.getServicesApi;
-      const extension = vscode.extensions.getExtension(`salesforce.${EXTENSION_NAME}`);
-      const extensionVersion = extension?.packageJSON?.version ?? 'unknown';
-      const o11yEndpoint = process.env.O11Y_ENDPOINT ?? extension?.packageJSON?.o11yUploadEndpoint;
-
-      const channelLayer = api.services.ChannelServiceLayer(extension?.packageJSON.displayName);
+      const channelLayer = api.services.ChannelServiceLayer(
+        context.extension.packageJSON.displayName ?? 'My Extension'
+      );
       const errorHandlerWithChannel = Layer.provide(api.services.ErrorHandlerService.Default, channelLayer);
 
       return Layer.mergeAll(
-        // list whatever you need.  TS will tell you if there's something missing
+        Layer.succeedContext(api.services.prebuiltServicesDependencies),
         ExtensionProviderServiceLive,
-        api.services.ConnectionService.Default,
-        api.services.EditorService.Default,
-        api.services.MediaService.Default,
+        errorHandlerWithChannel,
         api.services.ExtensionContextServiceLayer(context),
-        api.services.ProjectService.Default,
-        api.services.WorkspaceService.Default,
-        api.services.SdkLayerFor({ extensionName: EXTENSION_NAME, extensionVersion, o11yEndpoint }),
-        channelLayer,
-        errorHandlerWithChannel
+        api.services.SdkLayerFor(context),
+        channelLayer
       );
     }).pipe(Effect.provide(ExtensionProviderServiceLive))
   );
@@ -205,7 +211,6 @@ export const activateEffect = Effect.fn(`activation:${EXTENSION_NAME}`)(function
   const api = yield* (yield* ExtensionProviderService).getServicesApi;
   yield* api.services.ChannelService.appendToChannel('Extension activating');
 
-  // useful if registering multiple commands...they all get the layer provided to them
   const registerCommand = api.services.registerCommandWithLayer(AllServicesLayer);
 
   yield* registerCommand('sf.my.command', myCommandEffect);
@@ -216,9 +221,10 @@ export const activateEffect = Effect.fn(`activation:${EXTENSION_NAME}`)(function
 
 ## Common Patterns
 
-- Include `ExtensionContextServiceLayer(context)` when you have ExtensionContext
-- Use `MediaService.Default` when building UI strings in Effect; use direct `import { ICONS }` when outside Effect
-- Provide `ChannelServiceLayer` before `ErrorHandlerService`
-- Use `SdkLayerFor` with extension name/version for observability
-- Fork watchers with `Effect.forkIn(..., yield* getExtensionScope())` for cleanup on deactivation
-- Use `registerCommandWithLayer` for all commands (tracing + error handling)
+- Start with `Layer.succeedContext(api.services.prebuiltServicesDependencies)` — don't add individual `*.Default` for services already there
+- Only add per-extension layers on top
+- `import { ICONS }` outside Effect; `MediaService` inside Effect
+- `ChannelServiceLayer` before `ErrorHandlerService`
+- Pass `context` to `SdkLayerFor` (extracts name/version from ExtensionContext)
+- `Effect.forkIn(..., yield* getExtensionScope())` for watcher cleanup on deactivation
+- `registerCommandWithLayer` for all commands (tracing + error handling)

.vscode/launch.json

@@ -65,7 +65,6 @@
         "webpack:///salesforcedx-utils-vscode/./*": "${workspaceFolder}/packages/salesforcedx-utils-vscode/*",
         "webpack:///salesforcedx-vscode-soql/./*": "${workspaceFolder}/packages/salesforcedx-vscode-soql/*",
         "webpack:///salesforcedx-vscode-soql/../salesforcedx-utils-vscode/*": "${workspaceFolder}/packages/salesforcedx-utils-vscode/*",
-        "webpack:///salesforcedx-sobjects-faux-generator/./*": "${workspaceFolder}/packages/salesforcedx-sobjects-faux-generator/*",
         "webpack:///*": "*"
       },
       "preLaunchTask": "Compile and Bundle"
@@ -116,7 +115,6 @@
         "webpack:///salesforcedx-utils-vscode/./*": "${workspaceFolder}/packages/salesforcedx-utils-vscode/*",
         "webpack:///salesforcedx-vscode-soql/./*": "${workspaceFolder}/packages/salesforcedx-vscode-soql/*",
         "webpack:///salesforcedx-vscode-soql/../salesforcedx-utils-vscode/*": "${workspaceFolder}/packages/salesforcedx-utils-vscode/*",
-        "webpack:///salesforcedx-sobjects-faux-generator/./*": "${workspaceFolder}/packages/salesforcedx-sobjects-faux-generator/*",
         "webpack:///*": "*"
       }
     },
@@ -132,7 +130,6 @@
       "outFiles": ["${workspaceFolder}/packages/*/out/src/**/*.js"],
       "sourceMapPathOverrides": {
         "webpack:///salesforcedx-utils-vscode/./*": "${workspaceFolder}/packages/salesforcedx-utils-vscode/*",
-        "webpack:///salesforcedx-sobjects-faux-generator/./*": "${workspaceFolder}/packages/salesforcedx-sobjects-faux-generator/*",
         "webpack:///*": "*"
       },
       "preLaunchTask": "Compile and Bundle"
@@ -149,7 +146,6 @@
       "outFiles": ["${workspaceFolder}/packages/*/out/src/**/*.js"],
       "sourceMapPathOverrides": {
         "webpack:///salesforcedx-utils-vscode/./*": "${workspaceFolder}/packages/salesforcedx-utils-vscode/*",
-        "webpack:///salesforcedx-sobjects-faux-generator/./*": "${workspaceFolder}/packages/salesforcedx-sobjects-faux-generator/*",
         "webpack:///*": "*"
       },
       "preLaunchTask": "Compile and Bundle"
@@ -289,40 +285,12 @@
       "sourceMapPathOverrides": {
         "../../../../test/unit/": "${workspaceFolder}/packages/salesforcedx-apex-debugger/out/test/unit/*",
         "webpack:///salesforcedx-utils-vscode/./*": "${workspaceFolder}/packages/salesforcedx-utils-vscode/*",
-        "webpack:///salesforcedx-sobjects-faux-generator/./*": "${workspaceFolder}/packages/salesforcedx-sobjects-faux-generator/*",
         "webpack:///*": "*"
       },
       "preLaunchTask": "Compile and Bundle",
       "internalConsoleOptions": "openOnSessionStart",
       "skipFiles": ["<node_internals>/**"] // https://github.com/nodejs/node/issues/15464#issuecomment-332723120
     },
-
-    {
-      "name": "Launch Tests - SObject Faux Generator - Unit Tests",
-      "type": "node",
-      "request": "launch",
-      "cwd": "${workspaceFolder}/packages/salesforcedx-sobjects-faux-generator",
-      "program": "${workspaceFolder}/packages/salesforcedx-sobjects-faux-generator/node_modules/mocha/bin/_mocha",
-      "args": [
-        "-u",
-        "tdd",
-        "--timeout",
-        "100000",
-        "--colors",
-        "--recursive",
-        "${workspaceFolder}/packages/salesforcedx-sobjects-faux-generator/out/test/unit"
-      ],
-      "sourceMaps": true,
-      "smartStep": true,
-      "outFiles": ["${workspaceFolder}/packages/*/out/**/*.js"],
-      "sourceMapPathOverrides": {
-        "webpack:///salesforcedx-sobjects-faux-generator/../salesforcedx-utils-vscode/*": "${workspaceFolder}/packages/salesforcedx-utils-vscode/*",
-        "webpack:///salesforcedx-sobjects-faux-generator/./*": "${workspaceFolder}/packages/salesforcedx-sobjects-faux-generator/*",
-        "webpack:///*": "*"
-      },
-      "preLaunchTask": "Compile and Bundle",
-      "internalConsoleOptions": "openOnSessionStart"
-    },
     {
       "name": "Launch Tests - Replay Debugger - Unit Tests",
       "type": "node",
@@ -344,28 +312,12 @@
       "sourceMapPathOverrides": {
         "../../../../test/unit/": "${workspaceFolder}/packages/salesforcedx-apex-replay-debugger/out/test/unit/*",
         "webpack:///salesforcedx-utils-vscode/./*": "${workspaceFolder}/packages/salesforcedx-utils-vscode/*",
-        "webpack:///salesforcedx-sobjects-faux-generator/./*": "${workspaceFolder}/packages/salesforcedx-sobjects-faux-generator/*",
         "webpack:///*": "*"
       },
       "preLaunchTask": "Compile and Bundle",
       "internalConsoleOptions": "openOnSessionStart",
       "skipFiles": ["<node_internals>/**"] // https://github.com/nodejs/node/issues/15464#issuecomment-332723120
     },
-    {
-      "name": "Debug Faux Jest Unit Tests",
-      "cwd": "${workspaceRoot}/packages/salesforcedx-sobjects-faux-generator",
-      "type": "node",
-      "request": "launch",
-      "runtimeArgs": [
-        "--inspect-brk",
-        "${workspaceRoot}/packages/salesforcedx-sobjects-faux-generator/node_modules/.bin/jest",
-        "--runInBand",
-        "--coverage",
-        "false"
-      ],
-      "console": "integratedTerminal",
-      "internalConsoleOptions": "neverOpen"
-    },
     {
       "name": "Debug Apex Debug Jest Unit Tests",
       "cwd": "${workspaceRoot}/packages/salesforcedx-apex-debugger",

package.json

@@ -166,7 +166,6 @@
         "./packages/salesforcedx-vscode-i18n:compile",
         "./packages/salesforcedx-utils-vscode:compile",
         "./packages/soql-common:compile",
-        "./packages/salesforcedx-sobjects-faux-generator:compile",
         "./packages/salesforcedx-apex-debugger:compile",
         "./packages/salesforcedx-apex-replay-debugger:compile",
         "./packages/effect-ext-utils:compile",
@@ -200,7 +199,6 @@
         "./packages/salesforcedx-vscode-i18n:lint",
         "./packages/salesforcedx-utils-vscode:lint",
         "./packages/soql-common:lint",
-        "./packages/salesforcedx-sobjects-faux-generator:lint",
         "./packages/salesforcedx-apex-debugger:lint",
         "./packages/salesforcedx-apex-replay-debugger:lint",
         "./packages/effect-ext-utils:lint",
@@ -235,7 +233,6 @@
         "./packages/salesforcedx-vscode-i18n:test",
         "./packages/salesforcedx-utils-vscode:test",
         "./packages/soql-common:test",
-        "./packages/salesforcedx-sobjects-faux-generator:test",
         "./packages/salesforcedx-apex-debugger:test",
         "./packages/salesforcedx-apex-replay-debugger:test",
         "./packages/salesforcedx-lightning-lsp-common:test",