MODOD-1014: Add DEGREE_GRANTING_INSTITUTION to assignmentCheckDto; update README file.#488
Merged
Conversation
pkjacob
requested review from
PBobylev,
SKarolFolio,
Copilot and
zepheiryan
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
Adds support for a new authority-assignment-check target (DEGREE_GRANTING_INSTITUTION) to the public API contract, updates integration tests to cover the new target behavior, and aligns README examples with the current dissertation field predicates.
Changes:
- Extended
assignmentCheckDtoschema enum withDEGREE_GRANTING_INSTITUTION. - Updated
AuthorityAssignmentControllerITto use boolean expectations and added a new parameterized test for the new target. - Updated README dissertation example predicates (
label/year/note→note/date/miscInfo).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/test/java/org/folio/linked/data/e2e/endpoint/AuthorityAssignmentControllerIT.java | Adds a new parameterized integration test covering DEGREE_GRANTING_INSTITUTION target and simplifies expected-value typing. |
| src/main/resources/swagger.api/schema/assignmentCheckDto.json | Updates OpenAPI/JSON schema enum to include DEGREE_GRANTING_INSTITUTION. |
| README.md | Updates dissertation example predicates to match the current mapped fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
zepheiryan
approved these changes
Mar 25, 2026
PBobylev
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to fix an issue @SiarheiKarol noticed while testing
Add DEGREE_GRANTING_INSTITUTION to assignmentCheckDto